Skip to content

Fix failing theme tests - #220

Merged
swissspidy merged 2 commits into
mainfrom
fix/tests
Aug 6, 2026
Merged

Fix failing theme tests#220
swissspidy merged 2 commits into
mainfrom
fix/tests

Conversation

@swissspidy

@swissspidy swissspidy commented Aug 6, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Replaces moina with oceanly due to a change in PHP requirements in the former.

Summary by CodeRabbit

  • Tests
    • Updated the theme update scenario to install the Twenty Twelve theme version 1.0 with force enabled.

@swissspidy swissspidy added this to the 3.0.1 milestone Aug 6, 2026
Copilot AI lite review requested due to automatic review settings August 6, 2026 10:32
@swissspidy
swissspidy requested a review from a team as a code owner August 6, 2026 10:32
@swissspidy swissspidy added the scope:testing Related to testing label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f54c6ab-d917-481e-bdb9-69fbe1c2e467

📥 Commits

Reviewing files that changed from the base of the PR and between ef497c4 and 64c96f1.

📒 Files selected for processing (1)
  • features/check-theme-update.feature
🚧 Files skipped from review as they are similar to previous changes (1)
  • features/check-theme-update.feature
📝 Walkthrough

Walkthrough

The theme-update scenario now force-installs twentytwelve version 1.0 instead of installing moina version 1.1.2.

Changes

Theme update scenario

Layer / File(s) Summary
Update theme installation fixture
features/check-theme-update.feature		 The scenario force-installs twentytwelve at version 1.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing failing theme tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI reviewed Aug 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Behat acceptance test scenario for wp doctor check theme-update to avoid failures caused by the moina theme’s changed PHP requirements, by switching the test to use oceanly instead.

Changes:

  • Replaced wp theme install moina --version=1.1.2 with wp theme install oceanly --version=1.0.0 in the theme update warning scenario.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy
swissspidy merged commit 2008f46 into main Aug 6, 2026
63 checks passed
@swissspidy
swissspidy deleted the fix/tests branch August 6, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

scope:testing Related to testing

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@swissspidy